Disposal#1034
Merged
Merged
Conversation
henrydingliu
requested review from
genedan,
jbogaardt and
kennethshsu
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## disposal_rate_method #1034 +/- ##
=====================================================
Coverage 89.22% 89.22%
=====================================================
Files 91 91
Lines 5226 5226
Branches 666 666
=====================================================
Hits 4663 4663
+ Misses 396 394 -2
- Partials 167 169 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Medium Risk
The
disposal_terminal column construction change can alter downstream disposal patterns andfull_triangle_forecasts; tests add parity checks but actuarial outputs should be spot-checked.Overview
DisposalRate.fitappends the terminal development column todisposal_usingX.latest_diagonal*0 + 1instead ofult/ult, so the 100% disposal slice matches the paid triangle’s shape rather than the ultimate weight triangle.The
DisposalRatedocstring examples are rewritten aroundclrd/DisposalRate(emergence viadisposal_rate_tri, pattern indisposal_, forecast infull_triangle_), replacing the previous Berquist–Sherman trend copy-paste.Tests are reorganized and extended: Friedland fidelity is renamed, no-weight checks use the
raafixture, and new coverage asserts Chainladder parity on sparseraaand thatfull_triangle_stays a sparseCOOafterfit_transform.Reviewed by Cursor Bugbot for commit 4b8dea4. Bugbot is set up for automated code reviews on this repo. Configure here.